SHA-20: PROFILE scopes CORE/DOMAIN/FULL with gen field catalog - #57
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56e4db0f3e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| enum_types: list[EnumTypeSpec] = [] | ||
| for type_name in sorted(profile.types_by_name.keys()): | ||
| type_ = profile.types_by_name[type_name] | ||
| if type_.base_type is not BaseType.ENUM: |
There was a problem hiding this comment.
When FULL scope validates user_profile.activity_class, this condition treats the type as a closed set merely because its base type is ENUM. However, ActivityClass.LEVEL is a 0x7f mask, LEVEL_MAX is 100, and ATHLETE is a combinable 0x80 flag, so valid encoded levels such as 50 or ATHLETE | 50 are absent from PROFILE_ENUM_VALUES; _collect_closed_enum_findings consequently reports them as errors. Exclude ranged/bitfield enum families such as activity_class or represent their masks and ranges explicitly.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
==========================================
- Coverage 92.83% 92.72% -0.12%
==========================================
Files 35 36 +1
Lines 2625 2721 +96
Branches 437 461 +24
==========================================
+ Hits 2437 2523 +86
- Misses 112 117 +5
- Partials 76 81 +5 ☔ View full report in Codecov by Harness. |
Rebased onto main after Workout/Course FILE_TYPE. Adds ProfileScope, gen-exported field catalog, DOMAIN/FULL native checks. Codex P2: exclude ranged/bitfield enums such as activity_class from closed-enum validation. Co-authored-by: multica-agent <github@multica.ai>
56e4db0 to
c30aa21
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c30aa2176f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # ENUM base types that are ranges / bitfields, not closed value sets. | ||
| # Example: activity_class uses LEVEL mask 0x7f and ATHLETE flag 0x80. | ||
| _OPEN_OR_RANGED_ENUM_TYPES = frozenset({ | ||
| 'activity_class', |
There was a problem hiding this comment.
The earlier ranged-enum concern has fresh evidence in FileType: the generated profile defines MFG_RANGE_MIN = 247 and MFG_RANGE_MAX = 254, so intermediate manufacturer-defined file types are valid, yet only activity_class is excluded here and the catalog stores just the endpoints. Under DOMAIN/FULL, _collect_closed_enum_findings consequently reports FileIdMessage.type = 250 (and other values from 248 through 253) as outside file; add file to the ranged handling or encode its interval, then regenerate the catalog.
AGENTS.md reference: AGENTS.md:L53-L58
Useful? React with 👍 / 👎.
1 participant
Summary
Implements Multica SHA-20 (Stage 4 H) under architecture decision O1: grow
ConformanceLevel.PROFILEbeyond the developer-field subset toward data-driven rules from bundled Profile.xlsx21.205.0, without making FULL the default forstrict=True.What landed
ProfileScope:CORE|DOMAIN|FULLDEFAULT_PROFILE_SCOPE): developer-field rules + ambiguous subfield ERROR (unchanged default forDEFAULT_LEVELS/ Builderstrict=True)file_id,session,lap,record,event,device_info,workout,workout_step,activity)fit_tool/profile/field_catalog.py(1 406 fields, 101 closed enum types) viafit_tool/gen/field_catalog.py+gen-profileprofile_rule_coverage(scope)publishes message/field/enum coverage % for docs/testsvalidate_fit_file(..., profile_scope=...),FitFile.validate(..., profile_scope=...), package exportsnews/SHA-20.featureCoverage (FULL)
Not in this PR (honest Partial)
manufacturer, bitfields, …) intentionally excluded from closed-enum ERRORTest plan
uv run pytest fit_tool/tests/test_profile_scope.py fit_tool/tests/test_validation.py fit_tool/tests/test_public_api.pyuv run pytest(425 passed, 1 skipped)uv run ruff check fit_toolActivity.fitpassesProfileScope.FULL